upstart can race with cgmanager when using remove-on-empty
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Application Launcher |
Invalid
|
Critical
|
Ted Gould | ||
upstart |
Fix Released
|
Undecided
|
James Hunt | ||
cgmanager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
cgmanager (Ubuntu RTM) |
Fix Released
|
Undecided
|
James Hunt | ||
systemd-shim (Ubuntu) |
Invalid
|
Undecided
|
Stéphane Graber | ||
upstart (Ubuntu) |
Fix Released
|
Undecided
|
James Hunt | ||
upstart (Ubuntu RTM) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
After the ubuntu-app-launch landing in #188 (http://
Reproducable locally, where I got 11 such failures.
To reproduce:
[terminal 1]
1. flash/update device if needed
2. adb shell
3. apt install ubuntu-
4. powerd-cli display on bright # leave running, also unlock the screen so that lenses are shown
[terminal 2]
5. phablet-config autopilot --dbus-probe enable # wait until finishes
6. phablet-test-run ubuntuuitoolkit
A full test suite run will take around 0.5h and should produce a bunch of 'Application failed to start.':s.
Related branches
- Stéphane Graber (community): Approve
-
Diff: 503 lines (+287/-55)8 files modifiedChangeLog (+21/-0)
init/cgroup.c (+56/-53)
init/cgroup.h (+2/-0)
init/job.c (+30/-0)
init/job.h (+7/-0)
init/job_process.c (+15/-1)
init/job_process.h (+2/-1)
init/tests/test_job.c (+154/-0)
Changed in ubuntu-app-launch: | |
status: | New → Triaged |
importance: | Undecided → Critical |
assignee: | nobody → Ted Gould (ted) |
tags: | added: patch |
tags: | added: lt-blocker lt-category-visible lt-prio-high |
Changed in upstart: | |
assignee: | nobody → James Hunt (jamesodhunt) |
importance: | Undecided → Critical |
tags: | added: lt-whitelisted |
tags: | added: patch |
tags: | added: qa-daily-testing regression |
Changed in upstart: | |
status: | New → In Progress |
no longer affects: | linux (Ubuntu) |
tags: | removed: lt-whitelisted |
Changed in upstart: | |
status: | In Progress → Invalid |
importance: | Critical → Undecided |
Changed in systemd-shim (Ubuntu): | |
assignee: | nobody → Stéphane Graber (stgraber) |
summary: |
- Upstart jobs specifying cgroup fail to start occasionally + systemd-shim fails to handle cgmanager being unavailable |
Changed in systemd-shim (Ubuntu): | |
status: | New → Invalid |
Changed in ubuntu-app-launch: | |
status: | Incomplete → Invalid |
summary: |
- systemd-shim fails to handle cgmanager being unavailable + upstart can race with cgmanager when using remove-on-empty |
Changed in upstart: | |
status: | Invalid → In Progress |
Changed in upstart: | |
status: | In Progress → Fix Released |
Changed in upstart (Ubuntu): | |
assignee: | nobody → James Hunt (jamesodhunt) |
status: | New → Fix Released |
Changed in cgmanager (Ubuntu RTM): | |
status: | New → Triaged |
assignee: | nobody → James Hunt (jamesodhunt) |
Changed in upstart (Ubuntu RTM): | |
status: | New → Triaged |
Changed in cgmanager (Ubuntu RTM): | |
status: | Triaged → Fix Released |
I think this might be related to an error that Chipaca was seeing where Upstart wasn't able to make the cgroup for the task. Putting an Upstart task on this bug.