> [herrtimson] I wrote an email to Chris Coulson, asking for some assistance with the cflags. Hopefully he'll read it.
Thanks. I flagged him on #ubuntu-devel IRC as well. Hopefully we'll get his attention this time.
> > [Chituc] Can you check if the firefox 57.04 trusty , the working one shows
"-march=armv7-a -mfloat-abi=hard -mfpu=vfpv3-d16" in about:buildconfig ?
> [Chris] It’s not showing those flags in about:buildconfig
I don't think this matters, because Firefox 57 Trusty still has the Skia crash for most armhf users. The main difference between Firefox 57 and 58/59 is that in Firefox 57 it's possible to disable Skia via prefs.js, but otherwise the misaligned instruction bug is still there.
> it fixes freebsd only, but still it might be helpfull to see what they changed.
The majority of that patch deals with atomics, compare-and-swap, and memory barriers, although might be worth noticing that it does add -march=armv7-a
> [Chituc] Builing on xenial did nto worked but a build in trusty have great chances to work .
Right, but important to note that building on Bionic will likely work too. That point may be helpful in getting the Ubuntu team to prioritize.
In case anyone is testing this soon, be sure to set both CFLAGS and CXXFLAGS. SkJumper_generated.S is assembly and I'm not sure which of the two flag sets gets passed, but the Skia project is largely C++.
> [herrtimson] I wrote an email to Chris Coulson, asking for some assistance with the cflags. Hopefully he'll read it.
Thanks. I flagged him on #ubuntu-devel IRC as well. Hopefully we'll get his attention this time.
> > [Chituc] Can you check if the firefox 57.04 trusty , the working one shows ig ? ig
"-march=armv7-a -mfloat-abi=hard -mfpu=vfpv3-d16" in about:buildconf
> [Chris] It’s not showing those flags in about:buildconf
I don't think this matters, because Firefox 57 Trusty still has the Skia crash for most armhf users. The main difference between Firefox 57 and 58/59 is that in Firefox 57 it's possible to disable Skia via prefs.js, but otherwise the misaligned instruction bug is still there.
> it fixes freebsd only, but still it might be helpfull to see what they changed.
The majority of that patch deals with atomics, compare-and-swap, and memory barriers, although might be worth noticing that it does add -march=armv7-a
> [Chituc] Builing on xenial did nto worked but a build in trusty have great chances to work .
Right, but important to note that building on Bionic will likely work too. That point may be helpful in getting the Ubuntu team to prioritize.
> CFLAGS= "-march= armv7-a -mfloat-abi=hard -mfpu=vfpv3-d16"
In case anyone is testing this soon, be sure to set both CFLAGS and CXXFLAGS. SkJumper_ generated. S is assembly and I'm not sure which of the two flag sets gets passed, but the Skia project is largely C++.