Comment 4 for bug 838262

Please ignore the previous comment.

Yes, it seems reasonable to change TwistedStatsDClient.write as you suggest.

On Friday, 2 September 2011 at 13:59, Ian Wilkinson wrote:

> The fix is trivial as you suggest it. However there is nothing in
> Metrics that dictates the use of Twisted. We have a separation of
> client and server, where the server is a Twisted implementation, and
> the client is not necessarily running within a Twisted application.
>
> If the fix could respect both Twisted and non-Twisted use of Metrics
> I think that would be preferable.
>
>
> On Friday, 2 September 2011 at 13:32, Thomas Herve wrote:
>
> > Agreed. But we use it in a twisted application, so it's better to
> > benefit from the twisted loop, as it won't block. The fix is fairly
> > trivial, too.
> >
> > --
> > You received this bug notification because you are a member of txStatsD
> > Developers, which is the registrant for txStatsD.
> > https://bugs.launchpad.net/bugs/838262
> >
> > Title:
> > TwistedStatsDClient.write isn't thread-safe
> >
> > Status in txStatsD: A Twisted implementation of StatsD:
> > New
> >
> > Bug description:
> > write is meant to be called in threads sometimes, my Metric.send, for
> > example in WSGi application. It should use reactor.callFromThread to
> > be threadsafe/
> >
> > To manage notifications about this bug go to:
> > https://bugs.launchpad.net/txstatsd/+bug/838262/+subscriptions