def addHost(self, name, ip, weight=1):
- self.hosts[name] = HostConfig(name, ip, weight)
-
+ ## check that the ip is not alrady in our list
+ newHost = HostConfig(name, ip, weight) ##create the host first so we compare the ascii ip not the unicode ip
+ for host in self.hosts.values():
+ if newHost.ip == host.ip:
+ return False
+ self.hosts[name] = newHost
+ return True
Could you create a new ticket that more fully describes the issue this address, with some info on exactly how to duplicate the issue? Thanks!
Good news! I just pushed this with r212 on trunk.
Jehaih, I didn't commit the following:
def addHost(self, name, ip, weight=1): values( ):
- self.hosts[name] = HostConfig(name, ip, weight)
-
+ ## check that the ip is not alrady in our list
+ newHost = HostConfig(name, ip, weight) ##create the host first so we compare the ascii ip not the unicode ip
+ for host in self.hosts.
+ if newHost.ip == host.ip:
+ return False
+ self.hosts[name] = newHost
+ return True
Could you create a new ticket that more fully describes the issue this address, with some info on exactly how to duplicate the issue? Thanks!