I finally had a chance to look at these changes tonight; in your branch, I did the following:
bzr diff -r205..206
bzr diff -r208..209
For the most part, it looks great -- thanks! There are some minor formatting issues (lines need to be shorter that 80 chars, placeholder docstrings were removed, etc.) and I'm going to unify the saveConfig that you wrote and the one that already exists (implicitly) in manager.checker.checkConfigChanges.
There's a good chance I will get to this within the next couple of days.
Jehiah,
I finally had a chance to look at these changes tonight; in your branch, I did the following:
bzr diff -r205..206
bzr diff -r208..209
For the most part, it looks great -- thanks! There are some minor formatting issues (lines need to be shorter that 80 chars, placeholder docstrings were removed, etc.) and I'm going to unify the saveConfig that you wrote and the one that already exists (implicitly) in manager. checker. checkConfigChan ges.
There's a good chance I will get to this within the next couple of days.
Thanks again!