Comment 2 for bug 477902

Revision history for this message
Duncan McGreggor (oubiwann) wrote : Re: [Bug 477902] Re: txjsonrpc.auth has reference to twisted.web and twisted.web2

Sergey Kotov wrote:
> There are many ways to fix it.
> Duncan, I want to fix.
>
> May be divide auth to 2 modules in txjsonrpc/web/auth.py and
> tx~~/web2/auth ?
>

Yeah, I forget that folks don't just install all of Twisted ;-)

I think my preferred way to fix this would be to split that one import
into two, wrap a try/except block around it, and set the module (web or
web2) to None on ImportError. Then I'd raise an ImportError (with a nice
message) in the dependent functions below if the appropriate module was
None.

If this is something that you want to code, you can create a branch and
push it to lp:~yourusername/txjsonrpc/yourbranchname. Once it's done,
you can submit it for review, and I'll check it out and give you feedback.

If that's not what you meant, then I can code this up pretty quickly ;-)

Thanks!

d