Comment 2 for bug 930359

Revision history for this message
Drew Smathers (djfroofy) wrote :

Ok, no urgency on reviewing the ticket but I will just say this current ticket is lower in priority for my company (we really need new Agent support for streaming + multipart features). I'll get back to this ticket after those.

I would like to suggest we change the API to take "headers" argument instead of piecemeal. If you have other thoughts, let me know. For backwards compat we could deprecate usage of "content_type" keyword args etc and do deprecation warnings.

If we do decide to use headers keyword arg, my next questions are:

1. Should we require Headers object from twisted?
2. Plain dict?
3. Either and do type checking to coerce to Headers if dict?

Note that eventually we have to coerce to the Headers object to use with Agent API so far as I know.