Comment 7 for bug 767205

Revision history for this message
Drew Smathers (djfroofy) wrote :

Discussion on #twisted with idnar:

16:01 < idnar> anyhow, so, what I was thinking re: txAWS is
16:01 < idnar> it might be better to first replace getPage with Agent, without changing the txAWS API at all
16:02 < idnar> and then once that's done, look at extending the API to allow streaming uploads / downloads too
16:05 < djfroofy> idnar: ok, so first replace w/out fancy body producer, then add support for fancier producers (maybe just FS based) and corresponding apis as separate
                  feat?
16:05 < idnar> djfroofy: yeah, I think so
16:05 < djfroofy> idnar: but "optionally" replace at runtime is what we should do right? Agent support is pretty modern.
16:05 < idnar> hmm
16:06 < idnar> I'd lean toward just requiring a newish Twisted
16:06 < itamar> it's been in since ... 10.1 at least?
16:06 < itamar> since 9.0, in fact
16:06 < idnar> since 9.0, but a lot of the APIs are newer than that
16:06 < itamar> right
16:06 < idnar> eg. FileBodyProducer or whatever
16:07 < idnar> anyhow, you might want to raise the issue of backward compatibility on the mailing list, but I'd vote for just requiring 10.1 or 11.0 or whatever
16:07 < idnar> I can't remember, does Agent have 100-continue support yet?
16:07 < idnar> anyhow, that's an example of something we could take advantage with without changing the txAWS APIs at all
16:08 < idnar> and smaller branches are better than bigger branches, of course
16:08 < idnar> although I gather that for your purposes, using Agent without streaming support wouldn't help you much
16:08 < djfroofy> idnar: yes, this was turning into a bigger branch than i liked
16:09 < djfroofy> do we want to change the BaseQuery in txAWS to use Agent or just the extension used by s3?
16:10 < idnar> change BaseQuery, I think