Comment 2 for bug 1226835

Revision history for this message
Richard Wall (richardw) wrote :

I agree. Lets close this. I opened the ticket, but don't seem to have permission to close it.

14:47 < rwall> exarkun: In https://bugs.launchpad.net/twistedchecker/+bug/1226835 you mention PendingDeprecationWarning
14:48 < rwall> Shall I create a ticket to add PendingDeprecationWarning to all the affected assertions?
14:50 < rwall> Actually, no that's just going to cause all the same warnings as a standard deprecation
14:50 < rwall> https://twistedmatrix.com/trac/ticket/4990
14:52 < rwall> Sorry https://twistedmatrix.com/trac/ticket/4991
14:53 < exarkun> Ah that's less confusing.
14:54 < exarkun> Do I think that #4991 should be resolved? Sure, that'd be great. :)
14:54 < exarkun> (as long as Twisted itself has stopped using the deprecated APIs)
14:55 < rwall> So your point is, don't waste time adding new checks to twistedchecker, just do the work of replacing and then deprecating the old
               assertions.
14:56 < exarkun> well, I like that point, but I don't think it's the one I was making
14:56 -!- khorn1 [~<email address hidden>] has joined #twisted-dev
14:57 < exarkun> or maybe it was, I dunno
14:57 < exarkun> I don't think twistedchecker is the right tool to use in this case though
14:57 < rwall> Yep, I agree. I'll close the twistedchecker ticket. It's not worth the effort.
14:57 < exarkun> the APIs are going to be deprecated, deprecation warnings are the tool to help us deal with that
14:57 < exarkun> great, thanks