PXC Cluster Grow handles nic parameter inconsistently

[Morgan Jones]

The grow API for galera based clusters doesn't handle the nic parameters in a manner consistent with the create operation.

The Create API takes a nic parameter for each instance specified. The grow operation doesn't handle the nic parameter, if specified, but instead pics a network id from a random existing instance and sets it to every instance in the grow set.

This should be handled in a consistent manner.

Also, arguably, this should be handled consistently across all clusters.

[Doug Shelley (0-doug)]

Also, the code that does what is described above only appears to work for nova-network. When run in a cloud with Neutron, it fails with this error message (which is eaten silently due to [1]):
       Listing virtual interfaces is not supported by this cloud.

[1] https://bugs.launchpad.net/trove/+bug/1634627

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/389758

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/389758
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=741b86b4cd78073996a3f23c4b5dfcdeda24be15
Submitter: Jenkins
Branch: master

commit 741b86b4cd78073996a3f23c4b5dfcdeda24be15
Author: Duk Loi <email address hidden>
Date: Tue Oct 18 21:32:23 2016 -0400

    Remove nic handling in galera cluster grow

    Since the nic is required to be specified in the cluster grow,
    remove the unnecessary nic handling in the Galera cluster grow.

    This would make it consistent with the way all the other clusters
    are handling the nic parameter.

    Change-Id: I136141b3db78b7a0a1804bb5e3d4ca5cf4bc3bb3
    Closes-Bug: #1634629

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/trove 7.0.0.0b2 development milestone.