When the trove.taskmanager.models.FreshInstanceTasks#_create_server_volume_individually path is used, cinderclient is used to create the volume and then that volume is supplied in the block_device_mapping (BDM) in the novaclient call. delete_on_terminate is set to True in that BDM. However, in a scenario in which cinderclient succeeds and the subsequent novaclient fails (e.g. quota), the volume is not cleaned up since there is no nova server.
When the trove.taskmanag er.models. FreshInstanceTa sks#_create_ server_ volume_ individually path is used, cinderclient is used to create the volume and then that volume is supplied in the block_device_ mapping (BDM) in the novaclient call. delete_on_terminate is set to True in that BDM. However, in a scenario in which cinderclient succeeds and the subsequent novaclient fails (e.g. quota), the volume is not cleaned up since there is no nova server.