Comment 14 for bug 1981467

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/850307
Committed: https://opendev.org/openstack/tripleo-ansible/commit/99f2fb3f12d32c0185467f0a84dac64ea6209026
Submitter: "Zuul (22348)"
Branch: master

commit 99f2fb3f12d32c0185467f0a84dac64ea6209026
Author: John Fulton <email address hidden>
Date: Tue Jul 19 07:02:09 2022 -0400

    Require tripleo_ceph_client_vars to be overridden

    The roles tripleo_run_cephadm, tripleo_cephadm and
    tripleo_ceph_client all need tripleo_ceph_client_vars
    to be set consistently. However, they cannot be set
    consistently if they contain {{ playbook_dir }} because
    they are run in different contexts (config-download,
    python-tripleoclient and nested ansible executions).
    Thus {{ playbook_dir }} is not always the same. Also,
    the tripleo_ceph_client_vars must also be preserved on
    the system per stack for exports which can be run
    anytime in the future.

    Do not misleadingly default tripleo_ceph_client_vars
    and let roles which need them fail if they are not
    passed. Because the tripleo_ceph_client role supports
    more than just tripleo_ceph_client_vars as a source
    add condition so it can correctly handle when this
    variable is undefined.

    Change-Id: I0346bf1c6a3d8796a0aa70cbaac6e34b2f74fabb
    Related-Bug: #1981467