tripleo

  1. Bug #1969425
  2. Comment #5

Comment 5 for bug 1969425

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/839712
Committed: https://opendev.org/openstack/python-tripleoclient/commit/1a59023772d23c3c870621f02657536a4da57e42
Submitter: "Zuul (22348)"
Branch: master

commit 1a59023772d23c3c870621f02657536a4da57e42
Author: Jiri Podivin <email address hidden>
Date: Thu Apr 28 10:51:16 2022 +0200

    Mocking utils.check_deploy_backups in OvercloudDeploy tests

    The `check_deploy_backups` makes calls to `stat` which can potentially
    lead to I/O error in testing scenarios when the relevant file is
    removed after path retrieval but before `stat` is called.

    This can lead to tox test failure, in both CI and local environments.
    Mocking the utils.check_deploy_backups in tests where it is indirectly
    called should alleviate the problem.

    Long term solution would be mocking all built in functions performing I/O calls by default.

    Closes-Bug: #1969425

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I96d4bfce84ffe36d476e3383ee264cea6fd93c24