Comment 22 for bug 1954456

Ok, from [1] I think I see what is going on

There is no machine-id by the time grub2-mkinstall runs

2021-12-21 23:06:28.722 | ++ '[' -d /boot/loader/entries ']'
2021-12-21 23:06:28.722 | ++ '[' -e /etc/machine-id ']'
2021-12-21 23:06:28.722 | ++ read machine_id
2021-12-21 23:06:28.722 | + files=()

This is because it was cleared out prior by the triple-o element 70-remove-machine-id (https://opendev.org/openstack/tripleo-puppet-elements/src/branch/master/elements/remove-machine-id/)

2021-12-21 23:03:49.653 | dib-run-parts Running /tmp/in_target.d/post-install.d/70-remove-machine-id
2021-12-21 23:03:49.658 | dib-run-parts 70-remove-machine-id completed

Since the base sysprep element is included via redhat-common -- which clears the machine-id out (in 99- ... indeed https://review.opendev.org/c/openstack/diskimage-builder/+/818851 moved this) I think that triple-o should probably drop this separate machine-id removal element.

This is all ancient history, but it looks like this was added in about march 2017 with https://opendev.org/openstack/tripleo-puppet-elements/commit/c7c1da513eb003c1a60822b236bde08ace7ea083 ... but then dib added basically the same thing in about november 2017 (https://review.opendev.org/c/openstack/diskimage-builder/+/489013)

[1] https://logserver.rdoproject.org/13/36713/15/check/periodic-tripleo-ci-centos-9-ovb-1ctlr_1comp-featureset002-master/33b6783/logs/undercloud/home/zuul/build.log.txt.gz