Comment 15 for bug 1950528

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/825432
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/720b18fd8cb233aa809dd38ea71d1cf5ae39808f
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 720b18fd8cb233aa809dd38ea71d1cf5ae39808f
Author: Harald Jensås <email address hidden>
Date: Thu Oct 28 22:52:45 2021 +0200

    Add ping test for all networks gateway IPs

    Add ping test for gateway IPs on all networks, to ensure
    all gateways are reachable.

    The releated Bugzilla reports an issue where some network
    fabrics fail when using the current node ping test, which
    pings the first node in each role. The fabric simply does
    not forward traffic before the gateway has been pinged.

    One can argue that the fabric in question is broken. However,
    with the current implementation the first node in each role
    actually ping tests only against it's own address? So adding
    the test to ping the gateway addresses improves the validation
    in general.

    Make PingTestGatewayIPsMap a map of flatten lists

    PingTestGatewayIPsMap elements may contain list of lists, causing
    failures on roles that iterate over them. See [1] and #1950528 for
    more info.

    [1] https://review.opendev.org/c/openstack/tripleo-ansible/+/817500

    Add attr of networks and subnets to Networks resource

    In the Networks resource tempaltes add the full resource
    attributes to net_attributes_map. This is a partial cherry-pick of
    commit 5b3878580a9768be7c7c39d3062f567eb5e13767.

    Also the parameter {{role.name}}ControlPlaneSubnet is added in
    overcloud.yaml.j2, the parameter was previously only used in
    puppet/role.role.j2.yaml. This is a partial cherry-pick of
    commit 7b8c6b07dad3ddebbf9966fc6c8ba3e8a7b4cd8a.

    Conflicts:
      common/deploy-steps.j2

    Closes-bug: #1950528
    Related RHBZ#1875962
    Depends-On: I93cded61ffb862e99fd8043dbf0def3d16079692
    Depends-On: https://review.opendev.org/825676
    Change-Id: I3309f2a0e39ad115930ecd5c0e895816565819e9
    (cherry picked from commit 5d830980ec842c6093a8fd44ef922014bcadf693)
    (cherry picked from commit efc328c66898bfc09c5dcb00fe5f584a45b899ff)