Comment 14 for bug 1950528

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/825225
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/a61368ff2814aa4281055deca4fa5a6515cbc308
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit a61368ff2814aa4281055deca4fa5a6515cbc308
Author: Harald Jensås <email address hidden>
Date: Thu Oct 28 22:52:45 2021 +0200

    Add ping test for all networks gateway IPs

    Add ping test for gateway IPs on all networks, to ensure
    all gateways are reachable.

    The releated Bugzilla reports an issue where some network
    fabrics fail when using the current node ping test, which
    pings the first node in each role. The fabric simply does
    not forward traffic before the gateway has been pinged.

    One can argue that the fabric in question is broken. However,
    with the current implementation the first node in each role
    actually ping tests only against it's own address? So adding
    the test to ping the gateway addresses improves the validation
    in general.

    Make PingTestGatewayIPsMap a map of flatten lists

    PingTestGatewayIPsMap elements may contain list of lists, causing
    failures on roles that iterate over them. See [1] and #1950528 for
    more info.

    [1] https://review.opendev.org/c/openstack/tripleo-ansible/+/817500

    Related RHBZ#1875962
    Closes-bug: #1950528
    Depends-On: https://review.opendev.org/825228
    Change-Id: I3309f2a0e39ad115930ecd5c0e895816565819e9
    (cherry picked from commit efc328c66898bfc09c5dcb00fe5f584a45b899ff)
    (cherry picked from commit 5d830980ec842c6093a8fd44ef922014bcadf693)