If while a task is executing the ssh connection is severed, ansible will
automagically rerun the command under the covers. This causes problems
for long running 55-heat-config tasks as first process may have written
out the deployed json but not the notify.json that we use use to
determine if it was successful or not. This can lead to a failure
because the process either never runs to completion. This change
switches the execution to always be run async to ensure that ssh
interruptions won't cause inconsistent failures.
We previously saw a similar issue when invoking the NetworkDeployments
using this process. We've moved the network configurations to the
NetworkConfig task in THT/common/deploy-steps.j2 but this code is still
used to invoked with OS::Heat::SoftwareDeploymentGroup
Reviewed: https:/ /review. opendev. org/743780 /git.openstack. org/cgit/ openstack/ tripleo- common/ commit/ ?id=f38f6bdfa76 32d06cfec5e407d e9759656045071
Committed: https:/
Submitter: Zuul
Branch: stable/ussuri
commit f38f6bdfa7632d0 6cfec5e407de975 9656045071
Author: Alex Schultz <email address hidden>
Date: Tue Jul 28 14:02:53 2020 -0600
Switch 55-heat-config to async
If while a task is executing the ssh connection is severed, ansible will
automagically rerun the command under the covers. This causes problems
for long running 55-heat-config tasks as first process may have written
out the deployed json but not the notify.json that we use use to
determine if it was successful or not. This can lead to a failure
because the process either never runs to completion. This change
switches the execution to always be run async to ensure that ssh
interruptions won't cause inconsistent failures.
We previously saw a similar issue when invoking the NetworkDeployments deploy- steps.j2 but this code is still :SoftwareDeploy mentGroup
using this process. We've moved the network configurations to the
NetworkConfig task in THT/common/
used to invoked with OS::Heat:
Change-Id: Ic911bb6d999caf 2dc4afd4cff3d44 047c03dc8e4 e808c906e82abcf 116e0508c9)
Related-Bug: #1792343
Closes-Bug: #1887846
(cherry picked from commit 43aaaaa1190d7f5