Comment 4 for bug 1878153

Reviewed: https://review.opendev.org/727438
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=ea6e31cf87aacc80fa6cafc444e8654bc486bc02
Submitter: Zuul
Branch: master

commit ea6e31cf87aacc80fa6cafc444e8654bc486bc02
Author: Damien Ciabrini <email address hidden>
Date: Tue May 12 22:26:53 2020 +0200

    Fix puppetlabs/mysql dependency in metadata.json

    Recent version of puppetlabs/mysql [1] have removed the
    legacy (old API) function mysql_password and now expose
    it via the modern Ruby functions API [2].

    with the modern functions API, "if a module has a list
    of dependencies in its metadata.json file, it loads custom
    functions only from those specific dependencies." [3]

    Since puppet-tripleo explicitly calls mysql_password,
    we now have to fix metadata.json to explicit the
    dependency on puppetlabs/mysql.

    Related-Bug: #1878153

    [1] https://github.com/puppetlabs/puppetlabs-mysql/commit/39b7bdef1ae162b5d00be95459eafe31820cfd61
    [2] https://puppet.com/docs/puppet/5.5/functions_basics.html
    [3] https://puppet.com/docs/puppet/5.5/lang_write_functions_in_puppet.html#calling-a-function

    Change-Id: I5a89d0bf25c7973a69ee31d3dee6dc8151a9b1e2