Fix misused ansible connection timeout and deployment timeout passed in
config download and ansible runner utility.
Allow ansible runner utility to be given a job_timeout as well.
Also fix the misuse of timeout parameters in related worklows. Add
--overcloud-ssh-port-timeout and use it to configure ansible connection
timeout for the DeleteNode interace of the involved
workflows. Then use the timeout parameter as real timeout instead of
mistakingly passing it as a connection timeout.
Add new unit test for ansible timeout in config_download. Add missing
coverage for the existing timeout-related params in other unit tests.
Closes-Bug: #1868063
Co-authored-by: Kevin Carter <email address hidden>
Change-Id: I2a4d151bcb83074af5bcf7d1b8c68d81d3c0400d
Signed-off-by: Bogdan Dobrelya <email address hidden>
Reviewed: https:/ /review. opendev. org/713807 /git.openstack. org/cgit/ openstack/ python- tripleoclient/ commit/ ?id=9c602da4525 50fec4692832612 739bc8812bf400
Committed: https:/
Submitter: Zuul
Branch: master
commit 9c602da452550fe c4692832612739b c8812bf400
Author: Bogdan Dobrelya <email address hidden>
Date: Thu Mar 19 09:25:21 2020 +0100
Fix misused deployment vs connection timeouts
Fix misused ansible connection timeout and deployment timeout passed in
config download and ansible runner utility.
Allow ansible runner utility to be given a job_timeout as well.
Also fix the misuse of timeout parameters in related worklows. Add -ssh-port- timeout and use it to configure ansible connection
--overcloud
timeout for the DeleteNode interace of the involved
workflows. Then use the timeout parameter as real timeout instead of
mistakingly passing it as a connection timeout.
Add new unit test for ansible timeout in config_download. Add missing
coverage for the existing timeout-related params in other unit tests.
Closes-Bug: #1868063 4af5bcf7d1b8c68 d81d3c0400d
Co-authored-by: Kevin Carter <email address hidden>
Change-Id: I2a4d151bcb8307
Signed-off-by: Bogdan Dobrelya <email address hidden>