tripleo

  1. Bug #1863629
  2. Comment #4

Comment 4 for bug 1863629

Revision history for this message
John Fulton (jfulton-org) wrote : Re: tripleo-ansible ceph roles fail to correctly inherit calling ansible env

To improve how the env is inherited, Alex pointed out that `env`, as used in [1], is not going to contain quoted variables and now that ANSIBLE_SSH_ARGS is getting set with multiple "-o foo=bar" [2] we need to have those quotes in order for the inheritance to not break. A better way to fix this is to use something like [3].

[1] https://review.opendev.org/#/c/674706/4/tripleo_ansible/roles/tripleo-ceph-common/tasks/main.yml

[2] https://review.opendev.org/#/c/705793/21/tripleoclient/utils.py@360

[3] https://review.opendev.org/#/c/706143/15/roles/tripleo_overcloud_image_build/tasks/main.yml@13