Comment 9 for bug 1860556

Reviewed: https://review.opendev.org/704651
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=dddf584505bb24c53ba9d5fd92396695dc7a540c
Submitter: Zuul
Branch: stable/train

commit dddf584505bb24c53ba9d5fd92396695dc7a540c
Author: Cédric Jeanneret <email address hidden>
Date: Wed Jan 22 16:23:24 2020 +0100

    Make healthchecks more strict

    It was discovered that healthchecks aren't really reliable because they
    aren't strict enough.

    The current patch adds the "standard" options in order to ensure we
    actually catch errors soon enough in order to return the actual state of
    the checked element.

    It also requires a small change for the healthcheck_port() function,
    since the "piping" returned a 141 code instead of 0 due SIGPIPE being
    sent at some point[1].

    It also depends on two other changes, in order to ensure we won't get
    any "sudo" issues inside the checks (here again, healthcheck_port is
    tricky).

    [1] https://stackoverflow.com/questions/19120263/why-exit-code-141-with-grep-q
        http://www.tldp.org/LDP/lpg/node20.html

    Depends-On: https://review.opendev.org/703818
    Depends-On: https://review.opendev.org/703816
    Change-Id: Iada9fb49881c8edc9c6ede46a939d1853204f896
    Closes-Bug: #1860556
    Related: https://bugzilla.redhat.com/show_bug.cgi?id=1794044
    (cherry picked from commit ba02b0a23582b286b775fd129e3a09970862755b)