rhel8 3rd party jobs failing on build-test-packages, virtenv activation PS1 unbound variable

[wes hayutin]

2020-01-08 08:49:22.822367 | primary | TASK [build-test-packages : Map project name to DLRN project name] *************
2020-01-08 08:49:22.838734 | primary | Wednesday 08 January 2020 08:49:22 -0500 (0:00:01.270) 0:06:46.926 *****
2020-01-08 08:49:23.263371 | primary | fatal: [undercloud]: FAILED! => {
2020-01-08 08:49:23.263438 | primary | "changed": false,
2020-01-08 08:49:23.263463 | primary | "cmd": "set -euo pipefail; source /home/zuul/dlrn-venv/bin/activate; export PROJECT_NAME=$(echo openstack/tripleo-heat-templates | sed \"s|openstack/||\"); rdopkg findpkg -s $PROJECT_NAME -l rdoinfo | grep ^name | awk '{print $2}'\n",
2020-01-08 08:49:23.263480 | primary | "delta": "0:00:00.003946",
2020-01-08 08:49:23.263487 | primary | "end": "2020-01-08 08:49:23.240757",
2020-01-08 08:49:23.263501 | primary | "rc": 1,
2020-01-08 08:49:23.263510 | primary | "start": "2020-01-08 08:49:23.236811"
2020-01-08 08:49:23.263515 | primary | }
2020-01-08 08:49:23.263521 | primary |
2020-01-08 08:49:23.263525 | primary | STDERR:
2020-01-08 08:49:23.263531 | primary |
2020-01-08 08:49:23.263535 | primary | /home/zuul/dlrn-venv/bin/activate: line 57: PS1: unbound variable
2020-01-08 08:49:23.263541 | primary |
2020-01-08 08:49:23.263547 | primary |
2020-01-08 08:49:23.263551 | primary | MSG:
2020-01-08 08:49:23.263556 | primary |
2020-01-08 08:49:23.263561 | primary | non-zero return code

http://logs.rdoproject.org/80/696980/96/openstack-check/tripleo-ci-rhel-8-scenario001-standalone-rdo/34c2e22/job-output.txt

https://review.rdoproject.org/zuul/builds?job_name=tripleo-ci-rhel-8-scenario001-standalone-rdo

Started on Jan 08 2020 11:31 UTC

[Sorin Sbarnea (ssbarnea)]

Guess who attempted to fix this bug in virtualenv more than two years ago?
https://github.com/pypa/virtualenv/pull/1078

... until he gave up hope.

[Marios Andreou (marios-b)]

Not just rhel8

15:01 < marios> zbr|rover: this isn't just rhel8 https://bugs.launchpad.net/tripleo/+bug/1858890
15:01 < marios> zbr|rover: e.g. there too https://review.rdoproject.org/r/#/c/24339/

[Marios Andreou (marios-b)]

can we please revert/change that bit https://review.opendev.org/#/c/701116/4/roles/build-test-packages/tasks/dlrn-build.yml to unblock us? this will affect all the pipelines/master etc

[Marios Andreou (marios-b)]

fix there "Fix project name mapping to DLRN project name" Change-Id: I80bc67c6a17d87c24a2b90ca1577aa1f20902cf6 * https://review.opendev.org/#/c/701742/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/701967

[OpenStack Infra (hudson-openstack)]

Change abandoned by Federico Ressi (<email address hidden>) on branch: master
Review: https://review.opendev.org/701742
Reason: Change squashed to https://review.opendev.org/#/c/701921/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Federico Ressi (<email address hidden>) on branch: master
Review: https://review.opendev.org/701921
Reason: Fix to https://review.opendev.org/#/c/701742/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/701967
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=579584710717f6cdc2031c8641aeb60f374cb595
Submitter: Zuul
Branch: master

commit 579584710717f6cdc2031c8641aeb60f374cb595
Author: Sorin Sbarnea <email address hidden>
Date: Thu Jan 9 15:38:20 2020 +0100

    Fix project name mapping to DLRN project name (v2)

    This fixes failures produced when project name
    doesn't starts with 'openstack/'

    This is intended to unblock the use of tripleo-ci
    that is now failing with projects that are not
    hosted under the 'openstack/' prefix (like for
    example x/tobiko).

    Note: removed set -u because this can break source activate on old
    versions of virtualenv.

    The role should not fail when it fails to find a mapping, so it was
    refactored to assured that.

    Also assures that the html report of Ansible is colored, making it
    easier to read.

    Change-Id: Ibb562f818419373700177f3b2e665cd4eb5e32ef
    Partial-Bug: #1859167
    Partial-Bug: #1858890

[Sorin Sbarnea (ssbarnea)]

Mainly the root cause of this bug is outdated version on RHEL/centos: https://bugzilla.redhat.com/show_bug.cgi?id=1790174 because upstream virtualenv fixed the bug somewhere in 2018.

Workaround is to avoid using `set -u` before calling activate, which can be easy to miss because that is part of the recommended bash-strict mode.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Marios Andreou (<email address hidden>) on branch: master
Review: https://review.opendev.org/701968
Reason: it looks like they went with zbr change @ https://review.opendev.org/#/c/701967/13/roles/build-test-packages/tasks/dlrn-build.yml