Comment 10 for bug 1856865

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-upgrade (stable/train)

Reviewed: https://review.opendev.org/702199
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=6c5631bb3d128f79a7d114d8a19f928828c27138
Submitter: Zuul
Branch: stable/train

commit 6c5631bb3d128f79a7d114d8a19f928828c27138
Author: Jesse Pretorius (odyssey4me) <email address hidden>
Date: Mon Dec 23 10:09:07 2019 +0000

    Clean up roles data adjustment

    1. The python_bin var is unused, so it should be removed.
    2. Tasks should be seperated by a newline in order to easily see
       that they are seperate tasks.
    3. The return code of 2 was in the wrong place. It should have been
       where the data was changed, as per the changed_when condition.
    4. With the return code adjusted, the final task's condition also
       needed adjusting to match.

    Related-Bug: #1856865
    Change-Id: I916c3ed394f54561fff2a106288a667c0b877360
    (cherry picked from commit 967f3805d356c180835dba680d86af1b66ebe8f1)