(python-tripleoclient) openstack-tox-docs is broken blocking the gate

[Marios Andreou]

In [1][2][3] and lots of examples at [4] openstack-tox-docs is broken with trace like

        2019-10-23 17:01:58.711258 | ubuntu-bionic | Exception occurred:
        2019-10-23 17:01:58.711532 | ubuntu-bionic | File "/home/zuul/src/opendev.org/openstack/python-tripleoclient/.tox/docs/lib/python3.6/site-packages/tripleo_common/image/image_uploader.py", line 109, in get_undercloud_registry
        2019-10-23 17:01:58.711596 | ubuntu-bionic | % ctlplane_hostname)
        2019-10-23 17:01:58.711786 | ubuntu-bionic | tripleo_common.image.exception.ImageUploaderException: No entry for ubuntu-bionic-rax-dfw-0012454645.ctlplane in /etc/hosts
        2019-10-23 17:01:58.711987 | ubuntu-bionic | The full traceback has been saved in /tmp/sphinx-err-pwokbnkv.log, if you want to report the issue to the developers.
        2019-10-23 17:01:58.712165 | ubuntu-bionic | Please also report this if it was a user error, so that a better error message can be provided next time.
        2019-10-23 17:01:58.712324 | ubuntu-bionic | A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
        2019-10-23 17:01:59.033854 | ubuntu-bionic | ERROR: InvocationError for command /home/zuul/src/opendev.org/openstack/python-tripleoclient/.tox/docs/bin/sphinx-build -b html doc/source doc/build/html (exited with code 2)

Looks like this is related to [5] trying to catch Harald for more info

[1] https://storage.gra1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_430/690093/3/check/openstack-tox-docs/430f2e8/job-output.txt
[2] https://797b5dd0409eb6074a68-91d51f4a8e8b53e225c243f147f194be.ssl.cf2.rackcdn.com/690389/1/check/openstack-tox-docs/8cb3160/job-output.txt
[3] https://d1f716ee657057f8c1ed-5067ad0e5cf1f9e6b3e5798c03f452f6.ssl.cf5.rackcdn.com/690805/4/check/openstack-tox-docs/990422e/job-output.txt
[4] http://zuul.openstack.org/builds?job_name=openstack-tox-docs&project=openstack%2Fpython-tripleoclient
[5] https://review.opendev.org/#/c/687305/9

[Marios Andreou (marios-b)]

so do we need to pin https://github.com/openstack/python-tripleoclient/blob/90d7cf5b228843b080d869e45615aa127be3bb28/requirements.txt#L19 that to before https://review.opendev.org/#/c/687305/ ...

After that change, there was also https://review.opendev.org/#/c/690471/1/tripleo_common/image/image_uploader.py which looks like it will fix the issue... it *was* going to be reverted with https://review.opendev.org/#/c/690807/ but that was abandoned

Hoping to get hjensas to comment and confirm. So that might mean we are fixed again, but only after we get a cut of tripleo-common that includes https://review.opendev.org/#/c/690471 and we can bump requirements then

[Marios Andreou (marios-b)]

related bug at https://bugs.launchpad.net/tripleo/+bug/1849350 about the standalones (keeping this on though as it is different effect on the tox docs job)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/691286

[Marios Andreou (marios-b)]

so we need https://review.opendev.org/#/c/690989 and https://review.opendev.org/691286

[Harald Jensås (harald-jensas)]

https://review.opendev.org/#/c/690471/1/tripleo_common/image/image_uploader.py should fix the tox doc job.

I abandoned the revert https://review.opendev.org/#/c/690807/ because of the doc job. (I really thin returning 'localhost:8787' is'nt right either. But we also cannot raise an exception, since this breaks the doc job.

I agree, we need https://review.opendev.org/#/c/690989 and https://review.opendev.org/691286

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/691286
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=ec1629b7d30e8eb88a9be4e6ffb2368040504534
Submitter: Zuul
Branch: master

commit ec1629b7d30e8eb88a9be4e6ffb2368040504534
Author: Marios Andreou <email address hidden>
Date: Fri Oct 25 14:04:33 2019 +0300

    Bump tripleo-common requirements.txt to fix tox docs job

    We need latest tripleo-common from depends-on to fix the related
    bug.

    Depends-On: https://review.opendev.org/691370
    Change-Id: I3ee7b20db1dd67294b26048185df5a6c58822601
    Related-Bug: 1849788

[Marios Andreou (marios-b)]

changes merged (https://review.opendev.org/#/c/690989 and https://review.opendev.org/691286) and we now have green runs @ http://zuul.openstack.org/builds?job_name=openstack-tox-docs&project=openstack%2Fpython-tripleoclient

moving fix-released please change if you disagree