tripleo

get_undercloud_registry() no longer default to localhost - this break standalone

Bug #1849350 reported by Harald Jensås
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Harald Jensås

Bug Description

https://review.opendev.org/#/c/687305/9/tripleo_common/image/image_uploader.py stopped defaulting to 'localhost'. This break standalone which do not have hosts entries.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.opendev.org/690124

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.opendev.org/690124
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=7ca3a550b159717a4cbb49d8b31f93f8c48964fc
Submitter: Zuul
Branch: master

commit 7ca3a550b159717a4cbb49d8b31f93f8c48964fc
Author: Harald Jensås <email address hidden>
Date: Tue Oct 22 18:06:42 2019 +0200

    get_undercloud_registry() - Default to: 'localhost:8787'

    Standalone deployment does not have hosts entries. We cannot
    raise an error if the ctlplane entry is not present.

    This change reverts the function to return 'localhost' by default
    which was the behaviour prior to: https://review.opendev.org/687305

    Closes-Bug: #1849350
    Change-Id: Iba03ac88fa56d77d9f350b6c7f7d0c4276c104f4

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/690471

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/train)

Reviewed: https://review.opendev.org/690471
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=0eb79d311e129dbd596818b7ba83fbd0ab26a999
Submitter: Zuul
Branch: stable/train

commit 0eb79d311e129dbd596818b7ba83fbd0ab26a999
Author: Harald Jensås <email address hidden>
Date: Tue Oct 22 18:06:42 2019 +0200

    get_undercloud_registry() - Default to: 'localhost:8787'

    Standalone deployment does not have hosts entries. We cannot
    raise an error if the ctlplane entry is not present.

    This change reverts the function to return 'localhost' by default
    which was the behaviour prior to: https://review.opendev.org/687305

    Closes-Bug: #1849350
    Change-Id: Iba03ac88fa56d77d9f350b6c7f7d0c4276c104f4
    (cherry picked from commit 7ca3a550b159717a4cbb49d8b31f93f8c48964fc)

tags: added: in-stable-train
Revision history for this message
Marios Andreou (marios-b) wrote :

filed that for the tox docs job in tripleoclient https://bugs.launchpad.net/tripleo/+bug/1849788

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 11.3.1

This issue was fixed in the openstack/tripleo-common 11.3.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 12.0.0

This issue was fixed in the openstack/tripleo-common 12.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.