Reviewed: https://review.opendev.org/685667 Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=99a96ef416e04aaa133dfc5bd2f689e14e36354e Submitter: Zuul Branch: master
commit 99a96ef416e04aaa133dfc5bd2f689e14e36354e Author: Michele Baldessari <email address hidden> Date: Mon Sep 30 11:20:07 2019 +0200
Close some file descriptors that were left open
Before: (undercloud) [stack@undercloud-0 ~]$ openstack overcloud generate fencing --output fencetest.yaml instackenv.json /usr/lib/python3.6/site-packages/osc_lib/shell.py:176: ResourceWarning: unclosed file <_io.TextIOWrapper name='fencetest.yaml' mode='w' encoding='UTF-8'> ret_value = super(OpenStackShell, self).run_subcommand(argv) /usr/lib/python3.6/site-packages/osc_lib/shell.py:176: ResourceWarning: unclosed file <_io.TextIOWrapper name='instackenv.json' mode='r' encoding='UTF-8'> ret_value = super(OpenStackShell, self).run_subcommand(argv) sys:1: ResourceWarning: unclosed <ssl.SSLSocket fd=4, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('192.168.24.2', 56494), raddr=('192.168.24.2', 13000)> sys:1: ResourceWarning: unclosed <ssl.SSLSocket fd=9, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('192.168.24.2', 54102), raddr=('192.168.24.2', 13989)>
After: (undercloud) [stack@undercloud-0 ~]$ openstack overcloud generate fencing --output fencetest.yaml instackenv.json sys:1: ResourceWarning: unclosed <ssl.SSLSocket fd=4, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('192.168.24.2', 47694), raddr=('192.168.24.2', 13000)> sys:1: ResourceWarning: unclosed <ssl.SSLSocket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('192.168.24.2', 45306), raddr=('192.168.24.2', 13989)>
Note that we also explicitly close an opened FileType in tripleoclient/v1/overcloud_execute.py as it was spotted while writing this review.
NB: The SSL warnings will be investigated separately
Change-Id: Ic8122ad1982deed0434d797a3fb0fba8512b27ab Closes-Bug: #1845927
Reviewed: https:/ /review. opendev. org/685667 /git.openstack. org/cgit/ openstack/ python- tripleoclient/ commit/ ?id=99a96ef416e 04aaa133dfc5bd2 f689e14e36354e
Committed: https:/
Submitter: Zuul
Branch: master
commit 99a96ef416e04aa a133dfc5bd2f689 e14e36354e
Author: Michele Baldessari <email address hidden>
Date: Mon Sep 30 11:20:07 2019 +0200
Close some file descriptors that were left open
Before: lib/python3. 6/site- packages/ osc_lib/ shell.py: 176: ResourceWarning: unclosed file <_io.TextIOWrapper name='fencetest .yaml' mode='w' encoding='UTF-8'> Shell, self).run_ subcommand( argv) lib/python3. 6/site- packages/ osc_lib/ shell.py: 176: ResourceWarning: unclosed file <_io.TextIOWrapper name='instacken v.json' mode='r' encoding='UTF-8'> Shell, self).run_ subcommand( argv) AddressFamily. AF_INET, type=SocketKind .SOCK_STREAM, proto=6, laddr=( '192.168. 24.2', 56494), raddr=( '192.168. 24.2', 13000)> AddressFamily. AF_INET, type=SocketKind .SOCK_STREAM, proto=6, laddr=( '192.168. 24.2', 54102), raddr=( '192.168. 24.2', 13989)>
(undercloud) [stack@undercloud-0 ~]$ openstack overcloud generate fencing --output fencetest.yaml instackenv.json
/usr/
ret_value = super(OpenStack
/usr/
ret_value = super(OpenStack
sys:1: ResourceWarning: unclosed <ssl.SSLSocket fd=4, family=
sys:1: ResourceWarning: unclosed <ssl.SSLSocket fd=9, family=
After: AddressFamily. AF_INET, type=SocketKind .SOCK_STREAM, proto=6, laddr=( '192.168. 24.2', 47694), raddr=( '192.168. 24.2', 13000)> AddressFamily. AF_INET, type=SocketKind .SOCK_STREAM, proto=6, laddr=( '192.168. 24.2', 45306), raddr=( '192.168. 24.2', 13989)>
(undercloud) [stack@undercloud-0 ~]$ openstack overcloud generate fencing --output fencetest.yaml instackenv.json
sys:1: ResourceWarning: unclosed <ssl.SSLSocket fd=4, family=
sys:1: ResourceWarning: unclosed <ssl.SSLSocket fd=8, family=
Note that we also explicitly close an opened FileType in tripleoclient/ v1/overcloud_ execute. py
as it was spotted while writing this review.
NB: The SSL warnings will be investigated separately
Change-Id: Ic8122ad1982dee d0434d797a3fb0f ba8512b27ab
Closes-Bug: #1845927