Comment 4 for bug 1842988

Looking at the code I found some inconsistency in the way we set this "external_mac" value when the network type is VLAN. That also explains why Andreas gets it working after rebooting the node.

When we create the FIP this conditional is executed [0] which means that we won't set the "external_mac" field if the network type is VLAN.

Now, when we reboot the node. The port will flip to DOWN and the UP again and both of these status will generate an "event" which at the end will invoke this code here [1]. In the case of the event, we are *not* checking for the network type so the "external_mac" field gets set.

I believe we need to remove the VLAN check from [0].

[0] https://github.com/openstack/networking-ovn/blob/eda5d7f80d877601170631c5f5485370ea701f42/networking_ovn/common/ovn_client.py#L836-L837
[1] https://github.com/openstack/networking-ovn/blob/eda5d7f80d877601170631c5f5485370ea701f42/networking_ovn/ml2/mech_driver.py#L794-L800