Comment 8 for bug 1840641

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/stein)

Reviewed: https://review.opendev.org/737715
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=8ee23da39ae0ea7a9d0b44c89bcf3e07dab848f8
Submitter: Zuul
Branch: stable/stein

commit 8ee23da39ae0ea7a9d0b44c89bcf3e07dab848f8
Author: Michele Baldessari <email address hidden>
Date: Mon Aug 19 12:29:11 2019 +0200

    Make puppet-tripleo compatible with latest puppet-rabbitmq

    https://review.opendev.org/#/c/677082/ merged today and moved puppet-rabbitmq to 9.1.0
    which is breaking our spec tests:

    https://zuul.opendev.org/t/openstack/build/e767db93fe214514bebc065a64288548/log/job-output.txt

    So we error out with things like:
    2019-08-19 07:19:37.527187 | centos-7 | 1) tripleo::certmonger::rabbitmq on redhat-7-x86_64 behaves like tripleo::certmonger::rabbitmq should include the base for using certmonger
    2019-08-19 07:19:37.527435 | centos-7 | Failure/Error: include ::rabbitmq::params
    2019-08-19 07:19:37.527713 | centos-7 | Puppet::PreformattedError:
    2019-08-19 07:19:37.528769 | centos-7 | Evaluation Error: Error while evaluating a Function Call, Could not find class ::rabbitmq::params for centos-7-rax-ord-0010255916 (file: /home/zuul/workspace/spec/fixtures/modules/tripleo/manifests/certmonger/rabbitmq.pp, line: 51, column: 3) on node centos-7-rax-ord-0010255916

    Let's remove any reference to rabbitmq::params and also the following
    two notifies:
      File[$service_certificate] ~> Service<| title == $::rabbitmq::service_name |>
      File[$service_key] ~> Service<| title == $::rabbitmq::service_name |>

    They do nothing in a containerized deployment anyway.

    Tested as follows:
    - Full downstream OSP15 HA deploy

    Change-Id: Ib7c373c10ff7bcd8ec33cb912a8a0a4a32a196e2
    Closes-Bug: #1840641
    (cherry picked from commit 1e65c3f4fcc7b49c39a26fbe69a58a9677bdd2d0)