Comment 4 for bug 1832827

Reviewed: https://review.opendev.org/668519
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=f48331f36b5d00f5a28249da5f6f31e9bbf64db7
Submitter: Zuul
Branch: stable/stein

commit f48331f36b5d00f5a28249da5f6f31e9bbf64db7
Author: Jiri Stransky <email address hidden>
Date: Fri Jun 14 10:56:36 2019 +0200

    Fix tripleo-upgrade-hiera key deleting

    The commit fixes these issues:

    * When tripleo-upgrade-hiera key deleting was used multiple times in a
      playbook, the fact tripleo_upgrade_hiera_data_del persisted from the
      previous invocation instead of getting gradually filled from empty
      dict. This resulted in never deleting the keys except on the first
      run of the task.

    * When the key deleting was called in an Ansible `loop`, the external
      `item` variable and the internal `item` in the deleting code
      conflicted on naming, breaking the removal of the key. We now use
      `loop_var: upgrade_hiera_item` to avoid naming collisions.

    Closes-Bug: #1832827
    Change-Id: I3fa0717203f3f6eae852d019bec71e97eb485aa2
    (cherry picked from commit 6cfc204630c6771e27f946d64befa5d4107785ba)