* When tripleo-upgrade-hiera key deleting was used multiple times in a
playbook, the fact tripleo_upgrade_hiera_data_del persisted from the
previous invocation instead of getting gradually filled from empty
dict. This resulted in never deleting the keys except on the first
run of the task.
* When the key deleting was called in an Ansible `loop`, the external
`item` variable and the internal `item` in the deleting code
conflicted on naming, breaking the removal of the key. We now use
`loop_var: upgrade_hiera_item` to avoid naming collisions.
Reviewed: https:/ /review. opendev. org/665338 /git.openstack. org/cgit/ openstack/ tripleo- common/ commit/ ?id=6cfc204630c 6771e27f946d64b efa5d4107785ba
Committed: https:/
Submitter: Zuul
Branch: master
commit 6cfc204630c6771 e27f946d64befa5 d4107785ba
Author: Jiri Stransky <email address hidden>
Date: Fri Jun 14 10:56:36 2019 +0200
Fix tripleo- upgrade- hiera key deleting
The commit fixes these issues:
* When tripleo- upgrade- hiera key deleting was used multiple times in a upgrade_ hiera_data_ del persisted from the
playbook, the fact tripleo_
previous invocation instead of getting gradually filled from empty
dict. This resulted in never deleting the keys except on the first
run of the task.
* When the key deleting was called in an Ansible `loop`, the external
`item` variable and the internal `item` in the deleting code
conflicted on naming, breaking the removal of the key. We now use
`loop_var: upgrade_hiera_item` to avoid naming collisions.
Closes-Bug: #1832827 eae852d019bec71 e97eb485aa2
Change-Id: I3fa0717203f3f6