periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset016-queens is failing overcloud deploy - Failed running docker-puppet.py for collectd

[Ronelle Landy]

periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset016-queens has been failing the overcloud deploy step since 06/02 with the following error:

            "2019-06-03 05:52:12,444 ERROR: 21665 -- Failed running docker-puppet.py for collectd",
            "2019-06-03 05:52:12,444 ERROR: 21665 -- Notice: hiera(): Cannot load backend module_data: cannot load such file -- hiera/backend/module_data_backend",
            "2019-06-03 05:52:12,444 ERROR: 21665 -- + mkdir -p /etc/puppet",
            "+ '[' -n file,file_line,concat,augeas,cron,collectd_client_config ']'",
            "+ TAGS='--tags file,file_line,concat,augeas,cron,collectd_client_config'",
            "+ origin_of_time=/var/lib/config-data/collectd.origin_of_time",
            "+ touch /var/lib/config-data/collectd.origin_of_time",
            "+ /usr/bin/puppet apply --summarize --detailed-exitcodes --color=false --logdest syslog --logdest console --modulepath=/etc/puppet/modules:/usr/share/openstack-puppet/modules --tags file,file_line,concat,augeas,cron,collectd_client_config /etc/config.pp",
            "Warning: ModuleLoader: module 'collectd' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules",
            "Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, Failed to parse template collectd/plugin/python/module.conf.erb:",
            " Filepath: /usr/share/ruby/shellwords.rb",
            " Line: 73",
            " Detail: undefined method `scan' for 10:Fixnum",
            " at /etc/puppet/modules/collectd/manifests/plugin/python/module.pp:40:16 at /etc/puppet/modules/tripleo/manifests/profile/base/metrics/collectd/gnocchi.pp:173 on node upstream-centos-7-rdo-cloud-tripleo-0001978628.localdomain",
            "+ rc=1",
            "+ '[' 1 -ne 2 -a 1 -ne 0 ']'",
            "+ exit 1",

The full deploy log is here:

https://logs.rdoproject.org/openstack-periodic-24hr/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset016-queens/6b25741/logs/undercloud/home/zuul/overcloud_deploy.log.txt.gz

[Ronelle Landy (rlandy)]

https://github.com/openstack/puppet-tripleo/commit/2a9f0d89f10216f5d3915555f1b57faa9cddf8bc

possibly this change impacted it

Failing jobs:
2019-06-06 05:20:32 | --> Processing Dependency: puppet-collectd for package: puppet-tripleo-8.4.2-0.20190606021430.24568a6.el7.noarch

Passing jobs:
2019-06-01 05:12:10 | --> Processing Dependency: puppet-collectd for package: puppet-tripleo-8.4.2-0.20190531023726.cdc7c11.el7.noarch

[Martin Mágr (mmagr)]

Detail: undefined method `scan' for 10:Fixnum at /etc/puppet/modules/collectd/manifests/plugin/python/module.pp:40:16 sounds to me that there is some problem with puppet-collectd. Maybe we will need to update it for stable/queens to make that pass.

[Martin Mágr (mmagr)]

This is what I found in metadata.json for stable/queens:

# Note(bandini): Pinned due to LP#1756890
mod 'collectd',
  :git => 'https://github.com/voxpupuli/puppet-collectd',
  :ref => '93c8d0bd32bb5610652f30e785ba6644fc82a8b6'

stable/rocky+ follows master.

[Martin Mágr (mmagr)]

We still install stdlib 4.24 on stable/queens, so we will need to revert the patch (because of https://bugs.launchpad.net/tripleo/+bug/1756890).

[yatin (yatinkarel)]

Reverted patch:- https://review.opendev.org/#/c/663766/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/663766
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=5553f8df5051d817d8ef7e05e7c595a48912e355
Submitter: Zuul
Branch: stable/queens

commit 5553f8df5051d817d8ef7e05e7c595a48912e355
Author: Vinay Kapalavai <email address hidden>
Date: Thu Jun 6 20:38:04 2019 +0000

    Revert "Refactor collectd/gnocchi integration"

    This reverts commit 2a9f0d89f10216f5d3915555f1b57faa9cddf8bc.

    Closes-Bug: #1831893
    Change-Id: I8a06c25d9ef73d72c5ea30086ffa340d82ab1dfe

[Ronelle Landy (rlandy)]

Queens promoted - closing this out

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 8.5.0 release.