puppet-openstack-unit-4.8-centos-7 fail on stable/queens: Resource type not found: Stdlib::Fqdn

[Michele Baldessari]

From http://logs.openstack.org/53/554153/1/check/puppet-openstack-unit-4.8-centos-7/41ed5ef/job-output.txt.gz we see the following failures:
2018-03-19 08:20:20.446006 | centos-7 | 1) tripleo::profile::base::metrics::collectd on redhat-7-x86_64 behaves like tripleo::profile::base::metrics::collectd with defaults and step greater than 3 only have the collectd
2018-03-19 08:20:20.446153 | centos-7 | Failure/Error: is_expected.to compile.with_all_deps
2018-03-19 08:20:20.446512 | centos-7 | error during compilation: Evaluation Error: Resource type not found: Stdlib::Fqdn at /home/zuul/workspace/spec/fixtures/modules/collectd/manifests/init.pp:18:3 on node centos-7-rax-dfw-0003049823
2018-03-19 08:20:20.446777 | centos-7 | Shared Example Group: "tripleo::profile::base::metrics::collectd" called from ./spec/classes/tripleo_profile_base_metrics_collectd_spec.rb:64
2018-03-19 08:20:20.446987 | centos-7 | # ./spec/classes/tripleo_profile_base_metrics_collectd_spec.rb:32:in `block (4 levels) in <top (required)>'
2018-03-19 08:20:20.447024 | centos-7 |
2018-03-19 08:20:20.447384 | centos-7 | 2) tripleo::profile::base::metrics::collectd on redhat-7-x86_64 behaves like tripleo::profile::base::metrics::collectd Enabled file_logging and step greater than 3 Contains both
2018-03-19 08:20:20.447517 | centos-7 | Failure/Error: is_expected.to compile.with_all_deps
2018-03-19 08:20:20.447886 | centos-7 | error during compilation: Evaluation Error: Resource type not found: Stdlib::Fqdn at /home/zuul/workspace/spec/fixtures/modules/collectd/manifests/init.pp:18:3 on node centos-7-rax-dfw-0003049823
2018-03-19 08:20:20.448179 | centos-7 | Shared Example Group: "tripleo::profile::base::metrics::collectd" called from ./spec/classes/tripleo_profile_base_metrics_collectd_spec.rb:64
2018-03-19 08:20:20.448395 | centos-7 | # ./spec/classes/tripleo_profile_base_metrics_collectd_spec.rb:52:in `block (4 levels) in <top (required)>'
2018-03-19 08:20:20.448433 | centos-7 |
2018-03-19 08:20:20.448750 | centos-7 | 3) tripleo::profile::base::metrics::collectd on centos-7-x86_64 behaves like tripleo::profile::base::metrics::collectd with defaults and step greater than 3 only have the collectd
2018-03-19 08:20:20.448873 | centos-7 | Failure/Error: is_expected.to compile.with_all_deps
2018-03-19 08:20:20.449241 | centos-7 | error during compilation: Evaluation Error: Resource type not found: Stdlib::Fqdn at /home/zuul/workspace/spec/fixtures/modules/collectd/manifests/init.pp:18:3 on node centos-7-rax-dfw-0003049823
2018-03-19 08:20:20.449509 | centos-7 | Shared Example Group: "tripleo::profile::base::metrics::collectd" called from ./spec/classes/tripleo_profile_base_metrics_collectd_spec.rb:64
2018-03-19 08:20:20.449720 | centos-7 | # ./spec/classes/tripleo_profile_base_metrics_collectd_spec.rb:32:in `block (4 levels) in <top (required)>'
2018-03-19 08:20:20.449756 | centos-7 |
2018-03-19 08:20:20.450072 | centos-7 | 4) tripleo::profile::base::metrics::collectd on centos-7-x86_64 behaves like tripleo::profile::base::metrics::collectd Enabled file_logging and step greater than 3 Contains both
2018-03-19 08:20:20.450211 | centos-7 | Failure/Error: is_expected.to compile.with_all_deps
2018-03-19 08:20:20.450567 | centos-7 | error during compilation: Evaluation Error: Resource type not found: Stdlib::Fqdn at /home/zuul/workspace/spec/fixtures/modules/collectd/manifests/init.pp:18:3 on node centos-7-rax-dfw-0003049823
2018-03-19 08:20:20.450831 | centos-7 | Shared Example Group: "tripleo::profile::base::metrics::collectd" called from ./spec/classes/tripleo_profile_base_metrics_collectd_spec.rb:64
2018-03-19 08:20:20.451042 | centos-7 | # ./spec/classes/tripleo_profile_base_metrics_collectd_spec.rb:52:in `block (4 levels) in <top (required)>'

[Michele Baldessari (michele)]

Seems the following two commits in puppet-collectd broke us:
de0a96e86651 - (2018-03-17 00:12:21 +0100) feat: bump minimum puppetlabs/stdlib version to 4.25.0 <Marc Deop>
c0c5ba9357ea - (2018-03-16 23:54:58 +0100) feat: use Stdlib::Fqdn type for package_keyserver <Marc Deop>

And we seem to install 4.24:
2018-03-19 08:01:54.067044 | centos-7 | ├── puppetlabs-stdlib (v4.24.0) invalid

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/554246

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/554246
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=489d5502dad7f936fadb90a6ff97b98465414de5
Submitter: Zuul
Branch: master

commit 489d5502dad7f936fadb90a6ff97b98465414de5
Author: Michele Baldessari <email address hidden>
Date: Mon Mar 19 15:46:16 2018 +0100

    Pin puppet-collectd

    puppet-collectd introduced a change which requires stdlib 4.25:
    de0a96e86651 - (2018-03-17 00:12:21 +0100) feat: bump minimum puppetlabs/stdlib version to 4.25.0
    c0c5ba9357ea - (2018-03-16 23:54:58 +0100) feat: use Stdlib::Fqdn type for package_keyserver

    Let's pin the repo to the change which is already being used in RDO at
    https://github.com/redhat-openstack/rdoinfo/blob/master/rdo.yml#L1467

    (aka 93c8d0bd32bb5610652f30e785ba6644fc82a8b6 "Merge pull request #751 from bastelfreak/test")

    Closes-Bug: #1756890
    Change-Id: I197e8036a4f5c790a833d037d03ba6822f5488eb

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/554396

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/554396
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=be6b5ca52ea9a3db472a9cee60192b26a7451f2d
Submitter: Zuul
Branch: stable/queens

commit be6b5ca52ea9a3db472a9cee60192b26a7451f2d
Author: Michele Baldessari <email address hidden>
Date: Mon Mar 19 15:46:16 2018 +0100

    Pin puppet-collectd

    puppet-collectd introduced a change which requires stdlib 4.25:
    de0a96e86651 - (2018-03-17 00:12:21 +0100) feat: bump minimum puppetlabs/stdlib version to 4.25.0
    c0c5ba9357ea - (2018-03-16 23:54:58 +0100) feat: use Stdlib::Fqdn type for package_keyserver

    Let's pin the repo to the change which is already being used in RDO at
    https://github.com/redhat-openstack/rdoinfo/blob/master/rdo.yml#L1467

    (aka 93c8d0bd32bb5610652f30e785ba6644fc82a8b6 "Merge pull request #751 from bastelfreak/test")

    Closes-Bug: #1756890
    Change-Id: I197e8036a4f5c790a833d037d03ba6822f5488eb
    (cherry picked from commit 489d5502dad7f936fadb90a6ff97b98465414de5)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 8.3.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 9.0.0 release.