Comment 37 for bug 1831690

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/stein)

Reviewed: https://review.opendev.org/676169
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9ee30cdeb468e2154c9ba70d1d7c338240f5ea36
Submitter: Zuul
Branch: stable/stein

commit 9ee30cdeb468e2154c9ba70d1d7c338240f5ea36
Author: Jiri Stransky <email address hidden>
Date: Fri Aug 9 15:52:29 2019 +0200

    Check for rc instead of |succeeded

    We went from `ignore_errors: true` to `failed_when: false` to prevent
    Ansible printing errors which aren't really errors. When using
    `succeeded` filter on a registered variable from such task, we will
    always get true, which is not what we want. Check for `.rc == 0`
    instead to set the facts as they were intended.

    Change-Id: Ib8dea68720fda86cf4fd879cdf194d206968f6fb
    Partial-Bug: #1831690
    (cherry picked from commit e26009fa9c57d42a0c82ebc22169e10741005946)