Comment 10 for bug 1828859

Revision history for this message
Martin Kopec (mkopec) wrote :

This review [1] is wrong, it builds on a wrong presumption that [2] does something it doesn't. Based on that [3] is just a workaround, but it doesn't fix the original issue.

The original issue is, that python-tempestconf doesn't take into account that tempest_roles might be a list, therefore this condition [4] is wrong.

Give me some time, I'll send a review to fix that within today.

[1] https://review.opendev.org/#/c/660036/
[2] https://review.opendev.org/#/c/638617/
[3] https://review.opendev.org/#/c/660649/
[4] https://opendev.org/openstack/python-tempestconf/src/commit/e0d5dd6725f9a21090cae69a12bf087004a17e13/config_tempest/users.py#L76