Comment 2 for bug 1825366

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (master)

Reviewed: https://review.opendev.org/653739
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=f5d6110a79ca11f00728429660428ab99f5292d1
Submitter: Zuul
Branch: master

commit f5d6110a79ca11f00728429660428ab99f5292d1
Author: Damien Ciabrini <email address hidden>
Date: Thu Apr 18 15:29:33 2019 +0200

    Fix keepalived VIP monitoring script

    Currently keepalived monitors VIPs by running some shell commands
    that target HAProxy. The generated shell command is invalid, which
    makes keepalived log errors.

    Tue Apr 16 11:55:57 2019: Command = '/usr/bin/test' '-S' '/var/lib/haproxy/stats' '&&' 'echo' 'show'
    Tue Apr 16 11:55:57 2019: Script `haproxy` now returning 2
    Tue Apr 16 11:55:57 2019: VRRP_Script(haproxy) failed (exited with status 2)

    Fix quoting and invoke /bin/sh explicitely to fix the error:

    Thu Apr 18 13:16:35 2019: Command = '/usr/bin/sh' '-c' 'test -S /var/lib/haproxy/stats && echo show info | socat /var/lib/haproxy/stats stdio'
    Thu Apr 18 13:16:35 2019: VRRP_Script(haproxy) succeeded

    Change-Id: I5a757f88963270e77c8ec411cd292a30f89c6bc0
    Closes-Bug: #1825366