quickstart-extras validate-perf has invalid task attribute

[John Dennis]

tripleo-quickstart-extras/roles/validate-perf/tasks/main.yml causes ansible to immediately fail when ansible >= 2.7 used with the following error:

ERROR! 'executable' is not a valid attribute for a Task

This occurs because ansible 2.7 added this configuration option:

invalid_task_attribute_failed: true

formerly when ansible < 2.7 was used you would get this:

 [WARNING]: Ignoring invalid attribute: executable

The problem is the executable task attribute was declared outside of the task action, it just needs to be moved up and indented so it's part of the shell action instead of dangling below it as part of the task.

I have a patch prepared.

[Marios Andreou (marios-b)]

looking at this on request - looks like this should have fixed it?

 https://review.opendev.org/#/c/660100/ "Executable must be shells attribute, not tasks "

marking as fix released please move back if you disagree thanks

[John Dennis (jdennis-a)]

I agree, the above commit fixed the issue and it's appropriate to close this.