From 2bbf97167fb3468aa8ebff20850eb1aa67235afc Mon Sep 17 00:00:00 2001 From: John Dennis Date: Mon, 8 Apr 2019 16:27:18 -0400 Subject: [PATCH] fix validate-perf invalid task attribute executable Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit The "executable" keyword is a shell module parameter however it's declared as a task attribute because of it's location and indentation. Ansible 2.7 added the invalid_task_attribute_failed configuration option (default: true) which causes ansible to immediately fail with this error: ERROR! 'executable' is not a valid attribute for a Task ansible < 2.7 used to be more forgiving and you would get this warning instead and the playbook would continue to execute [WARNING]: Ignoring invalid attribute: executable This patch simply moves the executable key/value pair back up into the shell action where it should have been in the first place. Signed-off-by: John Dennis --- roles/validate-perf/tasks/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/validate-perf/tasks/main.yml b/roles/validate-perf/tasks/main.yml index e3e2bc7d..81a01293 100644 --- a/roles/validate-perf/tasks/main.yml +++ b/roles/validate-perf/tasks/main.yml @@ -20,9 +20,9 @@ --output /var/log/extra/{{ dstat_log_name }} {{ dstat_delay }} > /dev/null & + executable: /bin/bash async: 1 poll: 0 - executable: /bin/bash changed_when: false rescue: - debug: -- 2.20.1