Comment 8 for bug 1819482

Reviewed: https://review.opendev.org/657763
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=8cbdf9b52798537ea6a26c24b5adbbcbdcba4570
Submitter: Zuul
Branch: stable/queens

commit 8cbdf9b52798537ea6a26c24b5adbbcbdcba4570
Author: Michele Baldessari <email address hidden>
Date: Mon Mar 11 20:14:09 2019 +0100

    Fix kolla permissions errors inside nova_virtlogd

    [stack@win1 ~]$ sudo podman logs nova_virtlogd
    +sudo -E kolla_set_configs OSError: [Errno 30] Read-only file system

    The reason is the following nova_virtlogd bind mount:
     ... - /etc/libvirt/qemu:/etc/libvirt/qemu:ro

    Seems kolla config has a some empty folders that are then copied to a
    :ro fs and we fail:
    ()[root@win1 /]$ find
    var/lib/kolla/config_files/src/
    var/lib/kolla/config_files/src/
    var/lib/kolla/config_files/src/etc
    var/lib/kolla/config_files/src/etc/libvirt
    var/lib/kolla/config_files/src/etc/libvirt/qemu
    var/lib/kolla/config_files/src/etc/libvirt/qemu/networks
    var/lib/kolla/config_files/src/etc/libvirt/qemu/networks/autostart

    Since the above empty folders are due to the timestamp
    change caused by the default.xml file removal, let's do
    those on BM only.

    Hopefully compute folks can propose a more definitive fix that
    takes that default.xml removal logic into host-prep-task (if it
    is still needed)

    Tested on a RHEL8 OS/Containers combo and the error is gone:
    [root@overcloud-novacompute-0 ~]# podman logs nova_virtlogd 2>&1| tail -n5
    ++ chmod 755 /var/log/kolla/libvirt
    ++ chmod 644 /var/log/kolla/libvirt/libvirtd.log
    Running command: '/usr/sbin/virtlogd --config /etc/libvirt/virtlogd.conf'
    + echo 'Running command: '\''/usr/sbin/virtlogd --config /etc/libvirt/virtlogd.conf'\'''
    + exec /usr/sbin/virtlogd --config /etc/libvirt/virtlogd.conf

    Change-Id: I629e9e37aff9a1610df874b46c7a5b1eedd3e374
    Closes-Bug: #1819482
    (cherry picked from commit 7643761601a89823efee9bbbd92f2d05106fc129)