Check for physical_resource_id before getting deployments
Heat does non-strict validation of nested stack resources.
Most constraints are not enforced for nested stack resources
It's possible to set {Role}DeploymentActions as something like
[''] and it would not fail in validation. This would result in
a deployment resource with no physical_resource_id. The existing
check[1] for config-download would not be sufficient for some
cases as it can be another nested stack (we alias
both OS::Tripleo::SoftwareDeployment and
OS::Heat::StructuredDeployment).
Reviewed: https:/ /review. openstack. org/632011 /git.openstack. org/cgit/ openstack/ tripleo- common/ commit/ ?id=9b3e9b2c45e 3d694e46505eb51 79e6cbb8cb6a96
Committed: https:/
Submitter: Zuul
Branch: stable/rocky
commit 9b3e9b2c45e3d69 4e46505eb5179e6 cbb8cb6a96
Author: Rabi Mishra <email address hidden>
Date: Fri Jan 18 22:21:03 2019 +0530
Check for physical_ resource_ id before getting deployments
Heat does non-strict validation of nested stack resources. tActions as something like resource_ id. The existing :SoftwareDeploy ment and :Heat:: StructuredDeplo yment).
Most constraints are not enforced for nested stack resources
It's possible to set {Role}Deploymen
[''] and it would not fail in validation. This would result in
a deployment resource with no physical_
check[1] for config-download would not be sufficient for some
cases as it can be another nested stack (we alias
both OS::Tripleo:
OS:
[1] attributes[ 'value' ].get(' deployment' ) == \
'TripleOSoftw areDeployment'
deployment.
This adds a new check not to try and download heat deployments with resource_ id.
no physical_
Change-Id: I234e629cc5377c da8d5d01bfe4416 ad967cdc067 df49ca83a719329 38e9c84810)
Closes-Bug: #1812604
(cherry picked from commit 54c448f68354d48