Comment 4 for bug 1812604

Reviewed: https://review.openstack.org/632023
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=54c448f68354d48df49ca83a71932938e9c84810
Submitter: Zuul
Branch: master

commit 54c448f68354d48df49ca83a71932938e9c84810
Author: Rabi Mishra <email address hidden>
Date: Fri Jan 18 22:21:03 2019 +0530

    Check for physical_resource_id before getting deployments

    Heat does non-strict validation of nested stack resources.
    Most constraints are not enforced for nested stack resources
    It's possible to set {Role}DeploymentActions as something like
    [''] and it would not fail in validation. This would result in
    a deployment resource with no physical_resource_id. The existing
    check[1] for config-download would not be sufficient for some
    cases as it can be another nested stack (we alias
    both OS::Tripleo::SoftwareDeployment and
    OS::Heat::StructuredDeployment).

    [1]
    deployment.attributes['value'].get('deployment') == \
         'TripleOSoftwareDeployment'

    This adds a new check not to try and download heat deployments with
    no physical_resource_id.

    Change-Id: I234e629cc5377cda8d5d01bfe4416ad967cdc067
    Closes-Bug: #1812604