Ok so I investigated, and this is because puppet/services/haproxy-public-tls-inject.yaml is not included via composable services, so it doesn't end up in the EnabledServices list calculated in overcloud.j2.yaml.
This is a special-case where we directly instantiate OS::TripleO::Services::HAProxyPublicTLS inside ./puppet/services/haproxy.yaml, which is an anti-pattern in terms of composable services, but the fix I proposed should work (since these aren't really "services" but additional configuration for haproxy).
If CI passes I'll removed the WIP and we can go ahead with changing to haproxy_short_bootstrap_node_name.
Ok so I investigated, and this is because puppet/ services/ haproxy- public- tls-inject. yaml is not included via composable services, so it doesn't end up in the EnabledServices list calculated in overcloud.j2.yaml.
This is a special-case where we directly instantiate OS::TripleO: :Services: :HAProxyPublicT LS inside ./puppet/ services/ haproxy. yaml, which is an anti-pattern in terms of composable services, but the fix I proposed should work (since these aren't really "services" but additional configuration for haproxy).
If CI passes I'll removed the WIP and we can go ahead with changing to haproxy_ short_bootstrap _node_name.