Some legacy custom functions appear to be broken in the latest 5.5.7 release of Puppet.
http://logs.openstack.org/19/611919/4/check/puppet-openstack-unit-5.5-centos-7/eab07ad/job-output.txt.gz#_2018-10-24_16_33_42_017343
2018-10-24 16:33:42.017343 | centos-7 | 1) tripleo::keepalived on centos-7-x86_64 behaves like tripleo::keeplived with redis virtual ipv4 should contain Keepalived::Instance[53] with interface => "br-foo", virtual_ips => ["10.1.1.1/32 dev br-foo"], state => "MASTER", track_script => ["haproxy"] and priority => 101
2018-10-24 16:33:42.017367 | centos-7 | Failure/Error:
2018-10-24 16:33:42.017424 | centos-7 | is_expected.to contain_keepalived__instance('53').with(
2018-10-24 16:33:42.017454 | centos-7 | :interface => 'br-foo',
2018-10-24 16:33:42.017506 | centos-7 | :virtual_ips => [ "#{params[:redis_virtual_ip]}/32 dev br-foo" ],
2018-10-24 16:33:42.017536 | centos-7 | :state => 'MASTER',
2018-10-24 16:33:42.017568 | centos-7 | :track_script => ['haproxy'],
2018-10-24 16:33:42.017596 | centos-7 | :priority => 101
2018-10-24 16:33:42.017612 | centos-7 | )
2018-10-24 16:33:42.017624 | centos-7 |
2018-10-24 16:33:42.017767 | centos-7 | expected that the catalogue would contain Keepalived::Instance[53] with interface set to "br-foo" but it is set to "", and parameter virtual_ips set to ["10.1.1.1/32 dev br-foo"] but it is set to ["10.1.1.1/32 dev "]
2018-10-24 16:33:42.017791 | centos-7 | Diff:
2018-10-24 16:33:42.017803 | centos-7 |
2018-10-24 16:33:42.017827 | centos-7 | @@ -1,4 +1,4 @@
2018-10-24 16:33:42.017847 | centos-7 | -br-foo
2018-10-24 16:33:42.017863 | centos-7 |
2018-10-24 16:33:42.017904 | centos-7 | -10.1.1.1/32 dev br-foo
2018-10-24 16:33:42.017921 | centos-7 | +
2018-10-24 16:33:42.017947 | centos-7 | +10.1.1.1/32 dev
2018-10-24 16:33:42.018030 | centos-7 | Shared Example Group: "tripleo::keeplived" called from ./spec/classes/tripleo_keepalive_spec.rb:206
2018-10-24 16:33:42.018111 | centos-7 | # ./spec/classes/tripleo_keepalive_spec.rb:92:in `block (4 levels) in <top (required)>'
2018-10-24 16:33:42.018128 | centos-7 |
2018-10-24 16:33:42.027722 | centos-7 | 11) ip_to_erl_format should run ip_to_erl_format("192.168.2.1") and return "{192,168,2,1}"
2018-10-24 16:33:42.027784 | centos-7 | Failure/Error: it { should run.with_params('192.168.2.1').and_return('{192,168,2,1}') }
2018-10-24 16:33:42.027934 | centos-7 | expected ip_to_erl_format("192.168.2.1") to have returned "{192,168,2,1}" instead of raising NoMethodError(undefined method `function_ip_to_erl_format' for {}:Hash)
2018-10-24 16:33:42.028015 | centos-7 | # ./spec/functions/ip_to_erl_format_spec.rb:5:in `block (2 levels) in <top (required)>'
2018-10-24 16:33:42.028028 | centos-7 |
2018-10-24 16:33:42.030147 | centos-7 | 17) is_ip_addresses should run is_ip_addresses("192.168.2.1") and return true
2018-10-24 16:33:42.030238 | centos-7 | Failure/Error: it { should run.with_params('192.168.2.1').and_return(true) }
2018-10-24 16:33:42.030367 | centos-7 | expected is_ip_addresses("192.168.2.1") to have returned true instead of raising NoMethodError(undefined method `function_is_ip_addresses' for {}:Hash)
2018-10-24 16:33:42.030434 | centos-7 | # ./spec/functions/is_ip_addresses_spec.rb:5:in `block (2 levels) in <top (required)>'
2018-10-24 16:33:42.030448 | centos-7 |
2018-10-24 16:33:42.032913 | centos-7 | 24) lookup_hiera_hash should run lookup_hiera_hash("my_hash", "network") and return "127.0.0.1"
2018-10-24 16:33:42.032984 | centos-7 | Failure/Error: it { should run.with_params('my_hash', 'network').and_return('127.0.0.1') }
2018-10-24 16:33:42.033113 | centos-7 | expected lookup_hiera_hash("my_hash", "network") to have returned "127.0.0.1" instead of raising NoMethodError(undefined method `function_lookup_hiera_hash' for {}:Hash)
2018-10-24 16:33:42.033186 | centos-7 | # ./spec/functions/lookup_hiera_hash_spec.rb:8:in `block (2 levels) in <top (required)>'
2018-10-24 16:33:42.033200 | centos-7 |
2018-10-24 16:33:42.035580 | centos-7 | 31) netmask_to_cidr should run netmask_to_cidr("255.255.255.0") and return 24
2018-10-24 16:33:42.035642 | centos-7 | Failure/Error: it { should run.with_params('255.255.255.0').and_return(24) }
2018-10-24 16:33:42.035748 | centos-7 | expected netmask_to_cidr("255.255.255.0") to have returned 24 instead of raising NoMethodError(undefined method `function_netmask_to_cidr' for {}:Hash)
2018-10-24 16:33:42.035827 | centos-7 | # ./spec/functions/netmask_to_cidr_spec.rb:5:in `block (2 levels) in <top (required)>'
2018-10-24 16:33:42.035841 | centos-7 |
Fix proposed to branch: master
Review: https:/