Comment 12 for bug 1798525

Looking at the traces after merge that show the errors and the ones in the change job that do not, here is an observation ...

In job tripleo-ci-centos-7-undercloud-upgrades, "containerized_undercloud": false
In job tripleo-ci-centos-7-containerized-undercloud-upgrades, "containerized_undercloud": false.

#container_images_file = <None> in the undercloud.conf file

Looking at how the changes from a gating repo are included, they are added to a containers-prepare-parameter.yaml file as in: http://logs.openstack.org/30/605430/5/check/tripleo-ci-centos-7-undercloud-containers/5471e9d/logs/undercloud/home/zuul/containers-prepare-parameter.yaml.txt.gz.

and they are included in the undercloud.conf:

container_images_file = /home/zuul/containers-prepare-parameter.yaml

https://github.com/openstack/tripleo-upgrade/blob/master/tasks/upgrade/configure_uc_containers.yml#L28, the container_images_file is only updated if there is a custom one - not the default that would have been included if containerized_undercloud was true as in:

https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/undercloud-deploy/templates/undercloud.conf.j2#L294