And since now tripleo-heat-templates is branched(stable/rocky), all these tht patches would required to be cherry-picked there to unblock rocky promotions(as today we will be branching(rocky-rdo) it in RDO) and i think it would take time to get all those cherry-picks. So, if required can pin puppet-tripleo to a good hash in RDO and unblock rocky promotion.
<< Looks like https:/ /review. openstack. org/#/c/ 583670/ will fix it
So it's not just 583670, it includes lot's of commits under it. and yes with all those commit fs018 promotion job is passing, tested here:- https:/ /logs.rdoprojec t.org/43/ 13943/24/ check/legacy- periodic- tripleo- ci-centos- 7-multinode- 1ctlr-featurese t018-master/ 999bb47/ job-output. txt.gz# _2018-08- 26_20_39_ 54_361781, and the reverted comment should not be needed to fix the issue, but i think bnemec is trying to fix that circular dependency with that commit.
And since now tripleo- heat-templates is branched( stable/ rocky), all these tht patches would required to be cherry-picked there to unblock rocky promotions(as today we will be branching( rocky-rdo) it in RDO) and i think it would take time to get all those cherry-picks. So, if required can pin puppet-tripleo to a good hash in RDO and unblock rocky promotion.