Comment 8 for bug 1785825

Reviewed: https://review.openstack.org/599349
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=0279666fb75319c608b8b2a26292b272f57b0703
Submitter: Zuul
Branch: stable/queens

commit 0279666fb75319c608b8b2a26292b272f57b0703
Author: mandreou <email address hidden>
Date: Tue May 29 13:03:17 2018 +0300

    Remove --container-registry-file parameter from * upgrade clis

    Currently the container image registry references are passed with
    --container-registry-file in prepare but as -e in converge for
    the upgrade/update/ffwd-upgrade/ceph-upgrade clis.

    There is no special handling of the file, and it is ultimately
    included as any other environment file [1].

    This removes the --container-registry-file parameter from
    openstack overcloud [upgrade|update|ffwd-upgrade|ceph-upgrade]
    prepare.

    The related tripleo-common review is for removal of the parameter
    from the mistral workflow and action

    The related tripleo-docs patch is for updating the operator
    instructions to include the container image registry references
    using -e as any other environment file.

    [1] https://github.com/openstack/tripleo-common/blob/2c83dc964bc3a00504d580cbad8eb54f45fad8bf/tripleo_common/actions/package_update.py#L60
    Related: https://review.openstack.org/570903 tripleo-docs
    Partial-Bug: #1785825
    Co-Authored-By: Jiri Stransky <email address hidden>
    Depends-On: https://review.openstack.org/571186
    Change-Id: Id2811dbef59d1be2a35cea062eb7116648f52145
    (cherry picked from commit ac44a859378f28c017c918f7bfa318eb23acc99a)