Comment 28 for bug 1784155

Reviewed: https://review.openstack.org/623227
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f88dfe5a2dc544bc1a46b8606aa729565bd7d17f
Submitter: Zuul
Branch: stable/queens

commit f88dfe5a2dc544bc1a46b8606aa729565bd7d17f
Author: Martin Schuppert <email address hidden>
Date: Thu Nov 22 15:08:11 2018 +0100

    Change step to start nova placement and make compute wait for it

    There is a deployment race where nova-placement fails to start if
    the nova api db migration have not finished before starting it.
    We start nova placement early to make sure it is up before the
    nova-compute services get started. Since in HA scenario there is
    no sync in between the nodes on the current worked deployment step
    we might have the situation that the placement service gets started
    on C1/2 when the nova api db sync is not yet finished on C0.

    We have two possibilities:
    1) start placement later and verify that nova-computes recover correct
    2) verify that db migration on nova_api db finished before start nova-
    placement on the controllers

    2) which was addressed via https://review.openstack.org/610966 showed
    problems:
    a) the docker/podman container failed to start with some file not found
    error, therefore this was reverted in https://review.openstack.org/619607

    b) when the scrip were running on different controllers at the same
    time, the way how nova's db_version() is implemented has issues, which
    is being worked on in https://review.openstack.org/619622

    This patch addresses 1) and moves placement service start to step_4
    and adds an additional task on the computes to wait until the placement
    service is up.

    Closes-Bug: #1784155

    Change-Id: Ifb5ffc4b25f5ca266560bc0ac96c73071ebd1c9f
    (cherry picked from commit cc61ff93ec41e149caba31cc21524f37def4d07e)
    (cherry picked from commit 3363bcbf8d7a4c16ec673361adf82c76213e1cbd)