commit 629309217b13118ca83016cd9553c8a426c8a31d
Author: Jose Luis Franco Arza <email address hidden>
Date: Wed Jul 25 08:48:46 2018 +0200
Change include for include_tasks when including loop controled scripts.
We obtain a 'controllers' is undefined ansible error when
the tripleo-upgrade is run without any role related tag
(e.g. overcloud_upgrade, overcloud_update, etc...). The
issue seems to appear at the time of including the
controller_post_script.yml tasks, which content is defined
depending on the result of a shell command. As the command
is not executed during the role importing, the include fails.
The new include_tasks keyword seems to handle this issue
without displaying any error. Also the include keyword was
deprecated in Ansible 2.4, so it's time to start moving into
include_tasks/import_tasks.
Reviewed: https:/ /review. openstack. org/585654 /git.openstack. org/cgit/ openstack/ tripleo- upgrade/ commit/ ?id=629309217b1 3118ca83016cd95 53c8a426c8a31d
Committed: https:/
Submitter: Zuul
Branch: master
commit 629309217b13118 ca83016cd9553c8 a426c8a31d
Author: Jose Luis Franco Arza <email address hidden>
Date: Wed Jul 25 08:48:46 2018 +0200
Change include for include_tasks when including loop controled scripts.
We obtain a 'controllers' is undefined ansible error when post_script. yml tasks, which content is defined
the tripleo-upgrade is run without any role related tag
(e.g. overcloud_upgrade, overcloud_update, etc...). The
issue seems to appear at the time of including the
controller_
depending on the result of a shell command. As the command
is not executed during the role importing, the include fails.
The new include_tasks keyword seems to handle this issue tasks/import_ tasks.
without displaying any error. Also the include keyword was
deprecated in Ansible 2.4, so it's time to start moving into
include_
Change-Id: I9d10e1d9a95e11 fd59bf593bb052a bf9eb17cf78
Closes-Bug: #1783303