Lowercase any hostname comparisons in bootstrap_* scripts
If you deploy a stack with mixed-case hostnames things will break
because no task that is supposed to run on boostrap nodes will run
due to the following code:
HOSTNAME=$(/bin/hostname -s)
SERVICE_NODEID=$(/bin/hiera -c /etc/puppet/hiera.yaml
"${SERVICE_NAME}_short_bootstrap_node_name")
if [[ "$HOSTNAME" == "$SERVICE_NODEID" ]]; then
...
The hiera key might contain mixed-case letters whereas the hostname
won't and the end result is going to be that no bootstrap tasks
will run on any nodes and, amongst other things, no database tables
will be created, making all services unusable.
Since we use bash explicitely we can leverage the ${var,,} expression
for this.
Change-Id: Ie240b8a4217827dd8ade82479a828817d63143ba
Related-Bug: #1773219
(cherry picked from commit 3345557d7b64b29ccee258de8bcd6cfbfa88291e)
(cherry picked from commit 57dea6a3c77456b96d84d3e4f3d2881424194765)
Reviewed: https:/ /review. openstack. org/571714 /git.openstack. org/cgit/ openstack/ tripleo- common/ commit/ ?id=14f082d8e09 03fe98f1a280ddf 32a7f4fca553e4
Committed: https:/
Submitter: Zuul
Branch: stable/pike
commit 14f082d8e0903fe 98f1a280ddf32a7 f4fca553e4
Author: Michele Baldessari <email address hidden>
Date: Fri May 25 01:56:32 2018 +0200
Lowercase any hostname comparisons in bootstrap_* scripts
If you deploy a stack with mixed-case hostnames things will break $(/bin/ hostname -s) NODEID= $(/bin/ hiera -c /etc/puppet/ hiera.yaml SERVICE_ NAME}_short_ bootstrap_ node_name" )
because no task that is supposed to run on boostrap nodes will run
due to the following code:
HOSTNAME=
SERVICE_
"${
if [[ "$HOSTNAME" == "$SERVICE_NODEID" ]]; then
...
The hiera key might contain mixed-case letters whereas the hostname
won't and the end result is going to be that no bootstrap tasks
will run on any nodes and, amongst other things, no database tables
will be created, making all services unusable.
Since we use bash explicitely we can leverage the ${var,,} expression
for this.
Change-Id: Ie240b8a4217827 dd8ade82479a828 817d63143ba ccee258de8bcd6c fbfa88291e) 96d84d3e4f3d288 1424194765)
Related-Bug: #1773219
(cherry picked from commit 3345557d7b64b29
(cherry picked from commit 57dea6a3c77456b