commit 6f834f60e619181890c4438d1315ebaa776c1d09
Author: Alex Schultz <email address hidden>
Date: Thu Jan 4 16:23:37 2018 -0700
Use docker_config_scripts for puppet apply
There are some configuration applies that we need to do during the
deployment. These currently live as manually constructed bash runs which
are missing the --detailed-exitcode handling to know when we have
failures. In order to reduce the duplicated code and simplify this
exeuction, this change creates a docker_config_scripts with
docker_puppet_run.sh in containers-common that can be reused by any of
the docker services. This allows use to properly handle
--detailed-exitcodes while also reducing the amount of duplicated code
bits that we have within THT.
Additionally this change adds a new shared value for ContainersCommon to
pull the required volumes for the docker_puppet_apply.sh script into a
single place. Unfortunately the existing volumes from ContainersCommon
includes a mount for /etc/puppet to /etc/puppet which causes problems
because we need to be able to write out a hiera value. The /etc/puppet
mount is needed for the bootstrap_host_exec function which is consumed
by various docker_config tasks but the mount conflicts with the puppet
apply logic being used.
Reviewed: https:/ /review. openstack. org/531261 /git.openstack. org/cgit/ openstack/ tripleo- heat-templates/ commit/ ?id=6f834f60e61 9181890c4438d13 15ebaa776c1d09
Committed: https:/
Submitter: Zuul
Branch: master
commit 6f834f60e619181 890c4438d1315eb aa776c1d09
Author: Alex Schultz <email address hidden>
Date: Thu Jan 4 16:23:37 2018 -0700
Use docker_ config_ scripts for puppet apply
There are some configuration applies that we need to do during the config_ scripts with puppet_ run.sh in containers-common that can be reused by any of exitcodes while also reducing the amount of duplicated code
deployment. These currently live as manually constructed bash runs which
are missing the --detailed-exitcode handling to know when we have
failures. In order to reduce the duplicated code and simplify this
exeuction, this change creates a docker_
docker_
the docker services. This allows use to properly handle
--detailed-
bits that we have within THT.
Additionally this change adds a new shared value for ContainersCommon to puppet_ apply.sh script into a
pull the required volumes for the docker_
single place. Unfortunately the existing volumes from ContainersCommon
includes a mount for /etc/puppet to /etc/puppet which causes problems
because we need to be able to write out a hiera value. The /etc/puppet
mount is needed for the bootstrap_host_exec function which is consumed
by various docker_config tasks but the mount conflicts with the puppet
apply logic being used.
Depends-On: I24e5e344b7f657 ce5d42a7c7c45be 7b5ed5e6445 39bbb34c3a088c5 5e1f14fddca
Change-Id: Icf4a64ed76635e
Related-Bug: #1741345
Co-Authored-By: Damien Ciabrini <email address hidden>