Comment 10 for bug 1739026

Reviewed: https://review.openstack.org/529950
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=7534f0c398f6eadd944174cc84e8d0df5268fa11
Submitter: Zuul
Branch: stable/pike

commit 7534f0c398f6eadd944174cc84e8d0df5268fa11
Author: Michele Baldessari <email address hidden>
Date: Fri Dec 15 20:24:48 2017 +0100

    Only create veritas rabbitmq users on the bootstrap node

    Currently, when deploying an overcloud with veritas hyperscale, the
    hyperscale rabbitmq user gets created on all rabbit nodes. This is
    problematic on an HA deployment for two reasons:
    A) rabbitmq already mirrors users
    B) On non bootstrap node this will fail because the rabbit pcmk resource
    creation happens only on the bootstrap node, which means that when the
    hyperscale rabbitmq include kicks in on non-bootstrap nodes it will try
    to prefetch all rabbitmq users via 'rabbitmqctl -q list_users' and
    fail because there are no guarantees that rabbit is up and running since
    no rabbitmq puppet stuff gets executed there. I.e. on non-bootstrap
    nodes the Exec['rabbitmq-ready] -> Rabbitmq_users<||> won't work.

    While we're at it we move this rabbitmq user process to step2. rabbitmq
    get started and created at step2 so it makes no sense to invoke user
    creation before that.

    Note that this should be considered a short-term fix only. The proper
    fix should be (if possible) to move the veritas rabbitmq user
    configuration in the dedicated veritas service.

    Closes-Bug: #1739026

    Change-Id: I36950b9cec9f02a0de55292342a3a699df0b3cf1
    (cherry picked from commit 9fbfc6889dc8d7471a1ef409eceaa8ea6db2c8c1)